Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC] AccInputHash Problems #1002

Closed
revitteth opened this issue Aug 21, 2024 · 2 comments
Closed

[RPC] AccInputHash Problems #1002

revitteth opened this issue Aug 21, 2024 · 2 comments

Comments

@revitteth
Copy link
Collaborator

Initial solution (implemented):

Call the s/c, If it returns 0x00....set it to 0x00 (otherwise you are returning a accInputHash for the wrong batchNum)
if it returns a non-zero hash, just set it

Fix required:

Sync events SequenceBatches and from batch DB data you can compute all batches accInputHash and you store them in the DB.
When you save a batch in the DB during synchronization, also compute the accInputHash and store it.

@Sharonbc01
Copy link

Hey @revitteth is this done now.

@V-Staykov
Copy link
Collaborator

This is connected to this issue: #898

We've implemented a solution where we calculate the accInputHash upon request on the RPC in this PR:
#1161

I am closing the current issue, since it is kind of repeating the connected one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants