-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a command to export output notes from the cli #304
Comments
As part of this and as we discussed offline, we should also likely try to merge the note-related commands under a |
One way to do this is to never expose what's an input/output note to the CLI user. This way:
Obviously by doing that we'd lose the ability to export a note that is only in the input note records table, but in that situation:
Hence, it wouldn't make sense to import those input notes and then re-export them since we either have the serialized note already, or the other client can just sync with the node to receive the note if it was a public one. Is that assessment correct or am I missing something @igamigo @bobbinth |
One thing to keep in mind is that we may have the same not in both input and output tables - so, one open question is how to handle such duplicates.
Under what conditions do we need to import output notes or export input notes? I was thinking that:
|
I was trying to say this. Much clearer summary. Other flows (importing output note / exporting input note) don't make much sense |
closing as #318 got merged, it'll be included in the release of 0.3 |
Feature description
There should be a way for a user to export a note that is not currently in their input note list. Currently only input notes are able to be exported. We should also add a way to list output notes so that the user can see which notes they can export.
Why is this feature needed?
If a user creates a private output note that is meant for an untracked account they don't have a way to export it via de cli.
The text was updated successfully, but these errors were encountered: