Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get block authentication information for past blocks #306

Closed
tomyrd opened this issue Apr 29, 2024 · 2 comments · Fixed by #337
Closed

Get block authentication information for past blocks #306

tomyrd opened this issue Apr 29, 2024 · 2 comments · Fixed by #337
Milestone

Comments

@tomyrd
Copy link
Collaborator

tomyrd commented Apr 29, 2024

There's an edge case where we sync before we import the note and the note's block does not have any relevant notes for the client. So the MMR won't get updated and while we'll have the merkle path for the note, we won't be able to build the authentication path for the note's block.

Originally posted by @mFragaBA in #297 (comment)

@igamigo igamigo changed the title Update MMR when creating inclusion proof for imported notes Get block authentication information for past blocks Apr 29, 2024
@igamigo
Copy link
Collaborator

igamigo commented Apr 29, 2024

Changed the title a bit. This is currently blocked by 0xPolygonMiden/miden-node#256

@mFragaBA
Copy link
Contributor

closing as #337 got merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants