Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make block pool size customizable #626

Closed
Nashtare opened this issue Sep 13, 2024 · 0 comments
Closed

Make block pool size customizable #626

Nashtare opened this issue Sep 13, 2024 · 0 comments
Assignees
Labels
crate: zero_bin Anything related to the zero-bin subcrates.

Comments

@Nashtare
Copy link
Collaborator

The code snippet below:

// All proving tasks are executed concurrently, which can cause issues for large
// block intervals, where distant future blocks may be proven first.
//
// We then create a pool to limit the number of parallel proving block
// tasks, retrieving new blocks in increasing order when some block proofs are
// complete.
//
// While proving a block interval, we will output proofs corresponding to block
// batches as soon as they are generated.
const PARALLEL_BLOCK_PROVING_PERMIT_POOL_SIZE: usize = 16;
static PARALLEL_BLOCK_PROVING_PERMIT_POOL: Semaphore =
    Semaphore::const_new(PARALLEL_BLOCK_PROVING_PERMIT_POOL_SIZE);

is kind of limiting. I have to manually tweak it when testing every time, and will be heavily impacted by the activity of the targeted network, so it would be preferable to have it as configurable.

@github-project-automation github-project-automation bot moved this to Backlog in Zero EVM Sep 13, 2024
@Nashtare Nashtare added this to the System strengthening milestone Sep 13, 2024
@Nashtare Nashtare added the crate: zero_bin Anything related to the zero-bin subcrates. label Sep 13, 2024
@temaniarpit27 temaniarpit27 moved this from Backlog to In Progress in Zero EVM Sep 19, 2024
@temaniarpit27 temaniarpit27 moved this from In Progress to Ready to Review in Zero EVM Sep 19, 2024
@github-project-automation github-project-automation bot moved this from Ready to Review to Done in Zero EVM Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Status: Done
Development

No branches or pull requests

3 participants