Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

sol-compiler: build fails behind proxy since #1596 #2538

Closed
thorstenhirsch opened this issue Apr 6, 2020 · 2 comments
Closed

sol-compiler: build fails behind proxy since #1596 #2538

thorstenhirsch opened this issue Apr 6, 2020 · 2 comments
Labels

Comments

@thorstenhirsch
Copy link

Expected Behavior

build behind http proxy should work (as long as all internet connection use the http proxy)

Current Behavior

build fails with timeout when fetching list.json (solidity releases)

Possible Solution

With #1596 you changed from a static list of solidity releases to dynamically fetching it with this line:

src/utils/compiler.ts:        const versionList = await fetch('https://ethereum.github.io/solc-bin/bin/list.json');

However fetch is implemented in node-fetch, which does NOT respect http proxy configurations like environment variables or ~/.gitconfig. This seems to be done intentionally, the node-fetch guys write that node-fetch is on the wrong abstraction level, so if you're using it you have to implement the http proxy settings yourself (e.g. with an http-proxy-agent).

I suggest to switch from node-fetch to some other download library that respects environment variables http_proxy and https_proxy by default.

Steps to Reproduce (for bugs)

See ethereum-oasis-op/baseline#86.

Your Environment

Arch Linux (x64)
baseline (latest development version)
sol-compiler 4.0.2 (dependency of baseline)

@stale
Copy link

stale bot commented May 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 6, 2020
@stale
Copy link

stale bot commented Jun 5, 2020

This issue has been automatically closed because no activity occured in 7 days after being marked as stale. If it's still relevant - feel free to reopen. Thank you for your contributions.

@stale stale bot closed this as completed Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant