Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mining blocks at a certain interval #467

Closed
ivpavici opened this issue May 14, 2024 · 4 comments · Fixed by #491
Closed

Add mining blocks at a certain interval #467

ivpavici opened this issue May 14, 2024 · 4 comments · Fixed by #491
Assignees
Labels
enhancement New feature or request

Comments

@ivpavici
Copy link
Contributor

A new block should be created at a fixed time interval selected by the user.

This functionality exists in Anvil and Katana:

@ivpavici ivpavici added the enhancement New feature or request label May 14, 2024
@mikiw
Copy link
Contributor

mikiw commented May 14, 2024

I can take it since it's related to time and blocks

@mikiw mikiw self-assigned this May 14, 2024
@FabijanC
Copy link
Contributor

in CLI it could be governed by:

--block-generation <ON_DEMAND|PERIODIC>
--block-generation-period # only usable with --block-generation PERIODIC

@mikiw
Copy link
Contributor

mikiw commented Jun 5, 2024

requires a merge of https://github.com/0xSpaceShard/starknet-devnet-rs/pull/480/files but I already started based on this branch

@mikiw
Copy link
Contributor

mikiw commented Jun 7, 2024

I'll implement --block-generation-on <transaction|demand|<SECONDS> as discussed on the chat.

@mikiw mikiw linked a pull request Jun 12, 2024 that will close this issue
10 tasks
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in starknet-devnet-rs Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants