fix: return type and rename calldata

starknet-io · Nov 1, 2022 · 67fe081 · 67fe081
1 parent 1f8711d
commit 67fe081
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/__tests__/udc.test.ts b/__tests__/udc.test.ts
@@ -19,7 +19,11 @@ describe('Declare and UDC Deploy Flow', () => {
   test('UDC Deploy', async () => {
     const deployment = await account.deploy({
       classHash: erc20ClassHash,
-      callData: [encodeShortString('Token'), encodeShortString('ERC20'), account.address],
+      constructorCalldata: [
+        encodeShortString('Token'),
+        encodeShortString('ERC20'),
+        account.address,
+      ],
       salt: '123',
       unique: true, // Using true here so as not to clash with normal erc20 deploy in account and provider test
       isDevnet: IS_DEVNET,

diff --git a/src/account/default.ts b/src/account/default.ts
@@ -238,12 +238,12 @@ export class Account extends Provider implements AccountInterface {
       classHash,
       salt,
       unique = true,
-      callData = [],
+      constructorCalldata = [],
       isDevnet = false,
     }: UniversalDeployerContractPayload,
     transactionsDetail: InvocationsDetails = {}
-  ): Promise<any> {
-    const compiledCallData = compileCalldata(callData);
+  ): Promise<InvokeFunctionResponse> {
+    const compiledConstructorCallData = compileCalldata(constructorCalldata);
     return this.execute(
       {
         contractAddress: isDevnet ? UDC.ADDRESS_DEVNET : UDC.ADDRESS,
@@ -252,8 +252,8 @@ export class Account extends Provider implements AccountInterface {
           classHash,
           salt,
           toCairoBool(unique),
-          compiledCallData.length,
-          ...compiledCallData,
+          compiledConstructorCallData.length,
+          ...compiledConstructorCallData,
         ],
       },
       undefined,

diff --git a/src/types/lib.ts b/src/types/lib.ts
@@ -23,7 +23,7 @@ export type UniversalDeployerContractPayload = {
   classHash: BigNumberish;
   salt: string;
   unique: boolean;
-  callData?: RawArgs;
+  constructorCalldata?: RawArgs;
   isDevnet?: boolean;
 };