Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplication of code pulling posts #1016

Closed
1 task done
peterwilsoncc opened this issue Feb 19, 2023 · 0 comments · Fixed by #1017
Closed
1 task done

Reduce duplication of code pulling posts #1016

peterwilsoncc opened this issue Feb 19, 2023 · 0 comments · Fixed by #1017
Assignees
@peterwilsoncc
Labels
type:enhancement New feature or request.
Milestone
2.0.0

Comments

@peterwilsoncc
Copy link
Collaborator

Is your enhancement related to a problem? Please describe.

With the introduction of a post abstraction much of the duplication in the External and Network connection classes for pulling a post can be removed.

Follow up to PRs #964, #999 for issue #207

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@peterwilsoncc peterwilsoncc added type:enhancement New feature or request. v2 labels Feb 19, 2023
@peterwilsoncc peterwilsoncc added this to the 2.0.0 milestone Feb 19, 2023
@peterwilsoncc peterwilsoncc self-assigned this Feb 19, 2023
@peterwilsoncc peterwilsoncc mentioned this issue Feb 20, 2023
Merged
4 tasks
@jeffpaul jeffpaul moved this from 🆕 New to 👀 In review in Distributor 2.0.0 Apr 19, 2023
@jeffpaul jeffpaul moved this from Incoming to In Review in Open Source Practice Apr 19, 2023
@jeffpaul jeffpaul removed the v2 label May 8, 2023
@github-project-automation github-project-automation bot moved this from In Review to Merged in Open Source Practice May 26, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Distributor 2.0.0 May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterwilsoncc peterwilsoncc

Labels
type:enhancement New feature or request.
Projects
Open Source Practice
Archived in project
Distributor 2.0.0
Status: ✅ Done
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Reduce duplication pulling posts 10up/distributor
2 participants
@peterwilsoncc @jeffpaul