Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Consistency and understanding of when dt_push_post should happen #1044

Closed
1 task done
aaronware opened this issue Apr 6, 2023 · 1 comment
Closed
1 task done
Labels
type:question Further information is requested.

Comments

@aaronware
Copy link

aaronware commented Apr 6, 2023

Describe your question

I have been requesting various hooks and in doing so I started to think about if it was a matter of different hooks being utilized more consistently.

For example, from what I can tell on external connections dt_push_post only gets called on the first external push of a post but after doing a quick draft pull request #1043 I was wondering if instead of creating a new hook. Maybe infavor of more consistency do_action( 'dt_push_post'... should be utilized there as well?

I'm just not entirely understanding why ExternalConnection->push() isn't used when an already subscribed post is pushed when rest_insert_ is called. It seems to instead utilize send_notifications within includes/subscriptions.php

This is somewhat tied to the work that is being done in #712, #1018, #123

If we summarize a discussion here, I can gladly help w/ some documentation as well

Code of Conduct

  • I agree to follow this project's Code of Conduct
@aaronware aaronware added the type:question Further information is requested. label Apr 6, 2023
@aaronware
Copy link
Author

Looking at the develop branch and the substantial work done in #999 I don't think this question is actually relevant anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:question Further information is requested.
Projects
None yet
Development

No branches or pull requests

1 participant