-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block: Podcast Services #154
Comments
@cadic not sure if you feel this is worth milestoning into 1.4.0 or a future 1.5.0 release? |
@jeffpaul let's keep it in 1.4.0 along with other podcast blocks, I know @Sidsector9 already started with one of these. |
it would be enough to be able to add our own icons and services in the social link widget |
Available sample icons (color, black, white) here: https://drive.google.com/drive/folders/1gJSLI9iXcLpQ___a0A7WQWXVL_uPsEgt. Noting that's a 10up internal link, so if someone outside 10up is interested in a PR for this I can ZIP those up and post directly to this issue. Credit for that imagery should go to Stephanie Campbell (@sncampbell). |
Noting that @achchu93 is looking into this issue. |
@achchu93 are you still tracking work on this such that you can push up a PR or should I look to pull 10upper availability to help on a PR? |
@jeffpaul I'll raise the PR by today or tomorrow |
@jeffpaul This block can have some few controls for customisation:
@10up/open-source-practice have any thoughts on this? |
I'm fine with no-to-minimal controls at first and ones can be added based on community input. |
Noting that once this is released we'll want to assess if there are additional services that should be added, as I believe Amazon Music now includes podcasts and there may be others but will await community feedback before we iterate. |
Is your enhancement related to a problem? Please describe.
Many podcast sites like to promote all the various podcast services where they syndicate their content (e.g., Pocket Casts, Apple Podcasts) on their homepage and within individual episode posts. There's currently no way to do this in the core Social Icons block nor any other quick way to do this using Simple Podcasting. So I propose a block that would allow a site owner to enable/disable the various podcast services and which would provide a visual icon for each of those enabled services. Open to what we call the block, "Podcast Services" doesn't feel quite right but is the best I can quickly come up with right now.
The following appear to be a good listing of podcast services to include:
We'll probably want to include these services as new fields in the podcast settings so that the links to the podcast on each service is stored there and called into the block display for actual icon links.
Here's a good listing of the icons to use for each service (see "Player Icon Set"): https://www.podpage.com/badges/. As shown on the Apple Podcasts Identity Guidelines page, it might be nice to have black icons and white icons created from the full color versions on podpage.com and allow a site owner to chose from a full color, black, or white icon set for the display in the block.
Designs
Example icon display from WP Briefing:
Describe alternatives you've considered
Await initial inclusion of these services in the core Social Icons block: WordPress/gutenberg#36755.
Code of Conduct
The text was updated successfully, but these errors were encountered: