Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Pattern: Post Grid Block #84

Closed
1 task
Tracked by #208
jeffpaul opened this issue Mar 31, 2020 · 15 comments · Fixed by #214
Closed
1 task
Tracked by #208

Block Pattern: Post Grid Block #84

jeffpaul opened this issue Mar 31, 2020 · 15 comments · Fixed by #214
Assignees
Labels
help wanted Extra attention is needed needs:design This requires design to resolve. type:enhancement New feature or request.
Milestone

Comments

@jeffpaul
Copy link
Member

Is your enhancement related to a problem? Please describe.
With the advent of Block Patterns, we might want to consider a simple block pattern to cover the Post Grid Block concept.

Describe the solution you'd like

  • Output grid of episode posts with simple options for how many to render (2,4,6)

Designs

TBD, but ideal to help shape what we'd craft

Describe alternatives you've considered

n/a

Additional context

Block Pattern creation walkthroughs from the super rad @melchoyce.

@jeffpaul jeffpaul added type:enhancement New feature or request. help wanted Extra attention is needed needs:design This requires design to resolve. labels Mar 31, 2020
@jeffpaul jeffpaul added this to the 1.2.0 milestone Mar 31, 2020
@jeffpaul
Copy link
Member Author

This might be easier to accomplish now with the Query Loop block likely capable for handling most of this.

@jeffpaul jeffpaul modified the milestones: 1.3.0, 1.4.0 Aug 30, 2021
@ajmaurya99
Copy link

Hey @jeffpaul

In my understanding Block Patterns are used for the static content blocks, In our case we need something dynamic to fetch the latest three post with the Podcast taxonomy.

In this case we wont be able to use the Query Loop block also, Currently Query Loop block doesn't support custom taxonomies. It would say its still early for us to use Block Patterns in this case.

We have a few open issues in Gutenberg repo regarding adding support for custom taxonomies. It would be worth waiting for it.

WordPress/gutenberg#34977
WordPress/gutenberg#30706
WordPress/gutenberg#26304

Alternative, if we really want to ship something with Block Patterns then we need to develop a custom block to fetch latest posts with the Podcast Taxonomy.

@jeffpaul
Copy link
Member Author

@ajmaurya99 thanks for the research notes, that's very helpful! I would say in general it would probably be best to wait until the Query Loop block (or some other core block) is able to help solve for this issue as the need for the Post Grid block for this plugin is fairly basic in nature and once CPTs work in the Query Loop block would easily cover our needs here.

@ajmaurya99 ajmaurya99 removed their assignment Oct 13, 2021
@jeffpaul jeffpaul moved this to Incoming in Open Source Practice Dec 13, 2021
@jeffpaul jeffpaul moved this from Incoming to Backlog in Open Source Practice Dec 13, 2021
@cadic
Copy link
Contributor

cadic commented Dec 15, 2021

Wireframes for Post Grid Block: https://www.figma.com/file/14KjviZcFQZ1H6bIhSPwXa/Podcast-Block-Patterns?node-id=1%3A70

Credits: Nickolas Kola

@jeffpaul
Copy link
Member Author

jeffpaul commented Mar 1, 2022

Note that the Query Loop block can likely handle this functionality now, so likely worth bumping this in priority on the roadmap: https://make.wordpress.org/core/2022/02/03/whats-new-in-gutenberg-12-5-february-2nd/#query-loop-custom-taxonomies-filtering-and-more

@jeffpaul
Copy link
Member Author

Noting that @achchu93 is looking into this issue.

@achchu93
Copy link

As per the Figma design, there is a placeholder for duration. I identified going with a custom block for duration meta is the best practices. But now the question is, whether we gonna make a block which can pull the value with meta name or specifically fetch the value of duration meta. Need suggestion on this.

@jeffpaul
Copy link
Member Author

@cadic any thoughts on ^ this question?

@jeffpaul jeffpaul moved this from Backlog to In Progress in Open Source Practice Jun 14, 2022
@cadic
Copy link
Contributor

cadic commented Jun 15, 2022

@achchu93 the episode duration is stored in podcast_duration post meta. It is fetched automatically from the media file when adding the episode. It also could be overriden in a podcast block at a single post. I don't feel we need another place to override the duration. Let's just take the value from the post meta.

@cadic
Copy link
Contributor

cadic commented Jun 15, 2022

Since the stored value 12:34 is different than displayed 12 min, I think it's better to have a custom block "Podcast Duration" which will only display the duration meta (converted from MM:SS to .. hr .. min)

@jeffpaul
Copy link
Member Author

@achchu93 are you still working on a PR for this or should we unassign so someone else can pick up the issue?

@achchu93
Copy link

@jeffpaul Hey, I have completed all the functional tasks. Now we have left only the styling part. I can take a look at this start of next week if you allow me.

@jeffpaul
Copy link
Member Author

FYI, potentially related: Extending the Query Loop block dev note from WP 6.1.

@jeffpaul
Copy link
Member Author

@achchu93 could you please push up a branch or PR of your work, even if it's still in-progress?

@jeffpaul jeffpaul moved this from In Progress to To Do in Open Source Practice Jan 9, 2023
@jeffpaul jeffpaul moved this from To Do to In Progress in Open Source Practice Jan 16, 2023
@mehul0810
Copy link
Contributor

I have created a PR to add a block pattern for podcast grid. Let me know if there are any changes. Thanks!

CC: @jeffpaul

@cadic cadic modified the milestones: 1.4.0, 1.5.0 Jan 22, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Merged in Open Source Practice Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed needs:design This requires design to resolve. type:enhancement New feature or request.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants