Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persistent cache misses for beatmap id's missing from osu #2

Open
112batuhan opened this issue Oct 16, 2024 · 1 comment
Open

persistent cache misses for beatmap id's missing from osu #2

112batuhan opened this issue Oct 16, 2024 · 1 comment

Comments

@112batuhan
Copy link
Owner

112batuhan commented Oct 16, 2024

This is more of mental notes for later instead of concrete problem description. Please ignore. especially if I closed this. Which means I solved the issue.

SOOOO, some of the maps that the users added is not present in osu api. When we make a cached query, they are always missed. but then they aren't added in cache because requests with them returns empty, which means that they are never cached. which means we make a useless api call every time.

Solution: write a query to remove them from the database once they are found OR cache data wrapped in option to count them into cache. (thinking out loud)

I think I'm going to go with both ways, I will just wrap them into option to keep cache work and skip useless request, log the missing users in db and delete missing beatmaps from database

Detecting this issue isn't hard. If cache miss count and miss requests doesn't match, then we can understand that the maps or users are deleted.

I don't even know if this issue would show up in users (probably will). But they would be harder to deal with. (Let's just log them for now to see if is this even an issue.)

I'm offloading this to my future self as I need to finish higher priority stuff.

@112batuhan
Copy link
Owner Author

Now that the project is up and running, The banned users shouldn't be a problem as long as they are in the database. We need to have a way to skip them from daily updates.

As for beatmaps, We can have a separate function that spawns a task that runs a database query to find and delete missing beatmaps in our database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant