Skip to content
This repository was archived by the owner on Sep 19, 2021. It is now read-only.

Review screen - red icon in nav update time #179

Closed
ryanhofdotgov opened this issue May 23, 2018 · 4 comments
Closed

Review screen - red icon in nav update time #179

ryanhofdotgov opened this issue May 23, 2018 · 4 comments
Assignees

Comments

@ryanhofdotgov
Copy link
Contributor

From e-QIP-prototype-truetandem created by Jay-Neighbours-I72 : ryanhofdotgov/e-QIP-prototype-truetandem#2784

Currently user have to leave the review screen and come back for this indicator to update.

Can it update and change to green when all errors are fixed?

@ryanhofdotgov
Copy link
Contributor Author

@afeld afeld self-assigned this Jun 14, 2018
@afeld
Copy link
Contributor

afeld commented Jun 18, 2018

I think I've narrowed this down to the errorReducer(). Turns out this functionality is pretty baked in to how the navigation and error handling work, which are closely tied themselves. It's likely a few more days for me to understand it well enough to understand how to fix it without breaking everything.

@afeld
Copy link
Contributor

afeld commented Jul 10, 2018

Update (keeping notes for myself): the errors seem to be duplicated in the Review section.

  1. Filled out everything in Information about you, but with an invalid middle name

  2. Went to Review

  3. Checked the errors

    console.table($r.store.getState().application.Errors.identification.filter((e) => e.valid === false))

    screen shot 2018-07-10 at 1 00 22 am

  4. Fixed the middle name on the Review page

  5. Checked the errors again

    screen shot 2018-07-10 at 1 00 22 am copy

@afeld
Copy link
Contributor

afeld commented Jul 13, 2018

Update: the subsection is being passed from the SectionElement base class.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants