Fix EEPROM issues for Keymap Config #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix names for Keymap config EEPROM
drashna
force-pushed
the
magic_swap_ctrl_gui2
branch
from
9a14241 to
4bd2292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the Crtl-Gui configuration wasn't actually being retained in EEPROM, when resetting or power cycling the board.
Doing some digging .... the keymap_config_t structure uses a WORD (16 bit value), but the EECONFIG is only allocating a byte (8 bits).
This was fun, up until now, since it was only using 8 bits. However, adding Ctrl-GUI swapping exceeded the EEPROM allocation, and was getting truncated.
This adds another range for the EECONFIG storage, and fixes the functions to properly read from and write to EEPROM.