Swagger/struct generation now uses concrete types exclusively to simplify config object setup #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oapi-codegen
is the tool used to convert an OpenAPI spec file into Golang structs. By default, it sets optional parameter types to pointers, but this leads to clunky configuration for the user. This PR updates the swagger files in-place to appendoapi-codegen
's custom fieldx-go-type-skip-optional-pointer
to all parameters and schemas in the swagger spec.If possible, this should be done in a more native way (potentially using
oapi-codegen
's template framework). The current approach uses jq to update the swagger spec and could lead to unexpected behavior in at least two scenarios:jq
command is a blanket update to the swagger files and likely does not cover all edge cases. We will need to monitor this as more services are added/updatedAn issue was opened here on the
oapi-codegen
repo to ask the developers directly for a potential alternative to the jQuery approach.