-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added WiPhone LoRa support #1458
Conversation
That's great. Thanks for pushing this. I did not know about the WiPhone, it seems very interesting. |
Oops, I see that I messed up on the linting part. Is there something I could do? I noticed that it seems to reformat the code but the check still failed. By the way, WiPhone also has a GitHub repo, but their firmware source is still in the process of being developed and prepared for a first public release: https://github.com/ESP32-WiPhone |
You should be able to format automatically by a right click on the document from VSC, and click "Format document" |
Thanks, that worked better than I'd expect from my setup :) |
@kamaradclimber would you be interested in reviewing this PR as you were the previous commiter of this module |
@kamaradclimber let me know if you have any concerns regarding this PR; I don't want to break or hijack your code :) I'm currently using it as a hub for my WiPhone and also monitoring binary messages in my neighbourhood. Thanks / merci |
I'm fine, if any issue I'll fix them on my side ;) |
@1technophile is this PR something you could approve / merge? |
Thanks |
Thanks for the quick response! |
Description:
This PR enables decoding WiPhone LoRa packets.
WiPhone uses the RadioHead library which adds some extra bytes to the header, but is currently unused (as per default
0xFFFF0000
).The format is as followed:
I modified the LoRa to support more devices in the future, but I would like to see a mechanism similar as used in the rtl_433_ESP library;
Then again, this library does support the
sx127x
chipset (that also does LoRa) already, it only doesn't support the RFM9xW.Sending a message would be as simple as:
mosquitto_pub -h 127.0.0.1 -t "home/OpenMQTTGateway_ESP32_LORA/commands/MQTTtoLORA" -m '{"type":"WiPhone","from":"C0FFEE","to":"0","message":"Hello from OMG"}'
Incoming messages will look like:
home/OpenMQTTGateway_ESP32_LORA/LORAtoMQTT {"rssi":-113,"snr":5.5,"pferror":18748,"packetSize":34,"from":"123456","to":"000000","message":"hi from wiphone","type":"WiPhone"}
Checklist:
Notes:
To be honest, I'm not sure if people want to have the LoRa library extended to support decoding different payloads, but I thought it was the right thing to do (I came across this library which had all the fantastic features I needed, except LoRa payload decode support).
Also:
LORAdata["hex"]
(and the other way around)Taken from main/ZgatewaySRFB.ino
, but it might be better to have a helper class that one could use to do these conversions.Let me know what you think.
Cheers.