Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Drop System Random to Match Original Game Experience #545

Open
HarleyGilpin opened this issue Jul 22, 2024 · 0 comments
Open

Adjust Drop System Random to Match Original Game Experience #545

HarleyGilpin opened this issue Jul 22, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@HarleyGilpin
Copy link
Member

Description:

It has been observed that the current drop system using SecureRandom may be producing an unintended effect on the drop rates, leading to a less authentic gameplay experience compared to the original game.

Issue Details:

The current implementation uses SecureRandom for generating random drops, which is designed to provide cryptographically strong randomness. While this is beneficial for security purposes, it may not be suitable for gameplay where certain patterns are expected by players.
Players have reported that items, such as the air talisman or dark robes, are not dropping as frequently as expected. For instance, after killing hundreds of goblins, the air talisman has not dropped, which contrasts with the original game experience.
The original game likely used a simpler pseudo-random number generator (PRNG), which may have produced more predictable and consistent drop patterns.
Proposed Solution:

Switch to Regular Random:

Replace SecureRandom with java.util.Random to generate drops.
This change is expected to produce a drop experience more closely aligned with the original game.

@HarleyGilpin HarleyGilpin added the bug Something isn't working label Jul 22, 2024
@HarleyGilpin HarleyGilpin self-assigned this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant