Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling of attribute defaults #31

Closed
vegu opened this issue May 6, 2020 · 1 comment · Fixed by #37
Closed

Better handling of attribute defaults #31

vegu opened this issue May 6, 2020 · 1 comment · Fixed by #37
Assignees

Comments

@vegu
Copy link
Contributor

vegu commented May 6, 2020

if you have a ConfigSchema, it has a default, then it creates argparse with a default
so you can't tell if the value passed is actually passed in, or just left blank

There currently is an issue where default's cannot be reasonably determined in a setup that uses schema for cli arguments as well as config data objects.

@egfrank
Copy link
Contributor

egfrank commented Sep 29, 2020

Okay pushed again for the apply_argparse changes we were talking about:
f26c6da

@vegu vegu linked a pull request Feb 8, 2021 that will close this issue
@vegu vegu closed this as completed Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants