Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Construct modes are ranked incorrectly #1099

Closed
KonSola5 opened this issue Mar 1, 2024 · 3 comments
Closed

New Construct modes are ranked incorrectly #1099

KonSola5 opened this issue Mar 1, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@KonSola5
Copy link
Contributor

KonSola5 commented Mar 1, 2024

Ranking is inconsistent between gameplay and replay.

Seeing the mode file, A rank is supposed to be given after stacking 2 checkerboard lines (grade 8).

getRank=function(P)
local G=P.modeData.maxRankPts
return
G>=8 and 5 or
G>=6 and 4 or
G>=4 and 3 or
G>=2 and 2 or
G>=1 and 0
end,

This works fine... on replay only.

Replay - no rank at Grade 9

Gameplay - Grade 9 grants an A rank


This actually grants you an A rank.

@KonSola5
Copy link
Contributor Author

KonSola5 commented Mar 1, 2024

Same thing happens with Construct INVERSE SECRET GRADE.

@KonSola5
Copy link
Contributor Author

KonSola5 commented Mar 1, 2024

For the replay part:
Just noticed that the replay no longer shows rank progression in any mode.

@Not-A-Normal-Robot
Copy link
Member

This is either expected behavior or an off-by-one error made by MrZ when he edited the rank requirements.
P.modeData.maxRankPts = (lines) + 1.
IIRC I made it like this so the construct grade name function would be less complex

@shoucandanghehe shoucandanghehe added bug Something isn't working wait verify Questions awaiting further confirmation labels Mar 3, 2024
@MrZ626 MrZ626 closed this as completed in 8c4446e Mar 3, 2024
@shoucandanghehe shoucandanghehe removed the wait verify Questions awaiting further confirmation label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants