-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not put name of release in resource names by default #57
Comments
Review -> merge of #119 could close this. |
Actually, I've changed my mind. In this instance, given this project is still under the 2i2c umbrella, I'd suggest going with https://infrastructure.2i2c.org/contributing/code-review/#prime-directive instead. Which is to ask - what do you feel uncomfortable about with respect to this PR that another individual person can help with? Can you test it to know it works? If so, I'd recommend testing it and then merging it that way. If there's anything missed, I think that would be caught when we have to change our infrastructure to match. |
I've opened 2i2c-org/infrastructure#4370 to track bringing the change in once this is completed. |
If this chart is installed on a namespace named 'imagebuildig-demo' with the name 'imagebuilding-demo', then the service object is called 'imagebuilding-demo/imagebuilding-demo-binderhub-service'. This has a couple of negatives:
kubectl
, this really clutters the view and makes it quite difficult for me to see what is going on. I have to intentionally ignore more than half the characters in names before finding useful information. Reminds me of the dark days of https://en.wikipedia.org/wiki/Hungarian_notation.I know this is the default behavior of the directory that helm generates, but I'd appreciate us adopting what zero-to-jupyterhub does instead. It defaults to human readable names by default, and for the edge case of people trying to run multiple instances of the chart in one namespace, they can actually set override if they need be.
The text was updated successfully, but these errors were encountered: