Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] allEqual.test.js test arrays with different types in the same array #805

Merged
merged 3 commits into from
Oct 4, 2018
Merged

Conversation

itchylol742
Copy link
Contributor

Description

Resolves #804 - Adds a test for allEqual.test.js with an array that have different types.

PR Type

  • Snippets, Tests & Tags (new snippets, updated snippets, re-tagging of snippets, added/updated tests)
  • Scripts & Website & Meta (anything related to files in the scripts folder, how the repository's automated procedures work and the website)
  • Glossary & Secondary Features (anything related to the glossary, such as new or updated terms or other secondary features)
  • General, Typos, Misc. & Meta (everything else, typos, general stuff and meta files in the repository - e.g. the issue template)

Guidelines

@Chalarangelo Chalarangelo merged commit 6952738 into Chalarangelo:master Oct 4, 2018
Copy link

@susantruong susantruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@lock
Copy link

lock bot commented Dec 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for any follow-up tasks.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allEqual.test.js should test for arrays with different type items such as [1, '1', true]
3 participants