Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI bot configuration for pre-commit #11

Closed
dokempf opened this issue Sep 20, 2021 · 4 comments
Closed

Add CI bot configuration for pre-commit #11

dokempf opened this issue Sep 20, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@dokempf
Copy link
Collaborator

dokempf commented Sep 20, 2021

This is a new feature of pre-commit that will allow us to enforce e.g. code formatting etc.

@dokempf dokempf added the enhancement New feature or request label Sep 20, 2021
@lkeegan
Copy link
Contributor

lkeegan commented Sep 20, 2021

https://pre-commit.ci/ is one-click setup and works great - except that I found that clang-format didn't work.
This ci job basically does the same thing: https://github.com/ssciwr/hammingdist/blob/master/.github/workflows/ci.yml#L47

@dokempf
Copy link
Collaborator Author

dokempf commented Sep 20, 2021

I guess the clang-format issue is because the clang-format pip package is not available on all platforms and therefore the hook does not specify the dependency on clang-format in https://github.com/pocc/pre-commit-hooks/blob/master/.pre-commit-hooks.yaml#L11 Luckily, this will be fixed when the packaging issue in ssciwr/clang-format-wheel#4 is fully resolved.

@lkeegan
Copy link
Contributor

lkeegan commented Sep 20, 2021

very nice! I look forward to deleting my format ci job once this is available :-)
I came across this repo a while ago which might be a helpful reference in terms of building older versions on the various platforms: https://github.com/muttleyxd/clang-tools-static-binaries

@dokempf
Copy link
Collaborator Author

dokempf commented Oct 4, 2021

Pre-commit CI is enabled and working.

@dokempf dokempf closed this as completed Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants