-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unreliable behavior when equip load strictly equals weight threshold. #7
Comments
Are you 100% sure that literal equal condition never works? I'll check myself in a bit, but it seems odd that I haven't encountered this during the months I've been using it. I don't doubt your claim, maybe there's odd rounding going on. |
Sry, accidentally closed. |
I did some more testing. Unfortunately, the 70.0 result is inconsistent. I have two setups that reach 56.0 units of weight with my 80 load allowance. One can fast roll. The other cannot. If I select strictly pieces that are representable without loss in binary arithmetic (i.e. pieces with weight evenly divisible by 0.5), I get a fast roll. Maybe that helps. |
roflmao, did they write their own floating arithmetic? |
Hey, is there any chance my Data sets are wrong? There were rumors on r/darksouls3 about possible armor weight changes a few days back. |
I suppose it's possible, but it'd be unrelated to this issue. Your calculator gave me exactly the weight the game calculated -- but the result of that calculation was inconsistent on the fast roll threshold, depending on the pieces I used to get there. Sorry if I'm being unhelpful or too critical. I really like your tool. Thanks for providing it. |
Ok, my suspicion is that they may be using float instead of double floating point precision. Can you post exact equipment choices you had that conflict with the <70% rule? If we try to compute the weight fraction using floats maybe that will reveal something. |
For my testing, I equipped weapons with whole-integer weight until I had exactly 6.0 units of my 70% threshold left. So if you have 10 vitality (50 load), that's 35.0 units available. I spent 29.0 units of weight using only equipment that weighed a multiple of 1.0 units, leaving 6.0 units. With rings and gauntlets, I then spent my remaining weight:
" boosting" = Morne's Ring, Young Dragon Ring, Great Swamp Ring |
At 40 vigor, player characters have 80 equipment load available. The tool reports 56.0 weight setups as satisfying the default 0.7 "fast roll" criteria, but Dark Souls 3 gives these players a slow roll.
Intuitively, the default setting should provide a fast roll for the 70% burden setting, and the tool should mirror the game's test "less than" criteria, rather than using "less than or equal to".
EDIT: It appears that this edge case is inconsistent, and depends on From's rounding algorithm. They should be using integer math if they're going to be testing inequalities, but this is very evidently not the case.
The text was updated successfully, but these errors were encountered: