[WIP] THREESCALE-8002 - feat: product v1beta2 #810
Conversation
|
Code Climate has analyzed commit 68b6a19 and detected 162 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
| - supported: true | ||
| - supported: false | ||
| type: OwnNamespace | ||
| - supported: true | ||
| - supported: false |
There was a problem hiding this comment.
When adding conversion webhook, it looks like only AllNamespace install mode should be enabled, otherwise the bundle will fail validation
➜ 3scale-operator git:(THREESCALE-8002) ✗ make bundle-validate
/Users/chfan/dev/3scale-operator/bin/operator-sdk bundle validate ./bundle
INFO[0000] Found annotations file bundle-dir=bundle container-tool=docker
INFO[0000] Could not find optional dependencies file bundle-dir=bundle container-tool=docker
ERRO[0000] Error: Value : (3scale-operator.v0.0.1) only AllNamespaces InstallModeType is supported when conversionCRDs is present
make: *** [bundle-validate] Error 1
This would likely have other implications for upgrades
| webhookdefinitions: | ||
| - admissionReviewVersions: | ||
| - v1beta1 | ||
| - v1beta2 | ||
| containerPort: 443 | ||
| conversionCRDs: | ||
| - products.capabilities.3scale.net | ||
| deploymentName: threescale-operator-controller-manager-v2 | ||
| generateName: cproducts.capabilities.3scale.net | ||
| sideEffects: None | ||
| targetPort: 9443 | ||
| type: ConversionWebhook | ||
| webhookPath: /convert |
There was a problem hiding this comment.
This was added manually. For some reason, this is not generated and added automatically when generating the bundle. I still haven't found the reason for this, so if bundle are re-generated, this will be removed 🤔
|
@KevFan: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
KevFan
changed the title
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
superseded by #813 Shall we close this? |
Yup, I'll close this 👍 |
Still work in progress - not functioning as expected