Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug header does not work #216

Closed
mayorova opened this issue Jan 11, 2017 · 4 comments · Fixed by #217
Closed

Debug header does not work #216

mayorova opened this issue Jan 11, 2017 · 4 comments · Fixed by #217

Comments

@mayorova
Copy link
Contributor

mayorova commented Jan 11, 2017

When the X-3scale-debug header with the provider key as its value is sent to the APIcast, it should add the debug headers with the response.

This was broken after splitting the configuration, as _M.configuration.debug_header does not exist, as it's referring to configuration_store.lua and not configuration.lua as before.

@mayorova
Copy link
Contributor Author

mayorova commented Jan 11, 2017

Another affected field is: configuration.version

@mikz mikz added the type: bug label Jan 12, 2017
@mikz mikz self-assigned this Jan 12, 2017
@mikz
Copy link
Contributor

mikz commented Jan 12, 2017

I'm thinking about how to get rid of the provider key in the debug header.
Also the version should be scoped by service. Basically there should be no global configuration and everything should be scoped by service.

One of the options is to have different debug header for each service I'm considering the service token. It is already there and users already have access to it. So it kind of feels like natural way to have per service secret for the debug header. Wdyt?

@mikz mikz added this to the RHAMP 2.0 ER2 milestone Jan 12, 2017
@mayorova
Copy link
Contributor Author

The problem is that if you have multiple services configured, it would be a bit hard to know what service the request will be mapped to (especially when using path-based routing). I know that we are planning to remove the provider key from the JSON spec, but I don't know what would be a reasonable alternative :/

@mikz
Copy link
Contributor

mikz commented Jan 12, 2017

@mayorova I'd consider it almost a feature. If you get the header back when using path based routing, you know it routed right :)
But yeah, I see the issue. Not sure what we can do about it right now. IMO each service should have unique token because they are independent and one person does not have to have access to all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants