[proxy] new proxy interface v0.1 #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikz
force-pushed
the
proxy-interface
branch
4 times, most recently
from
5b7c836 to
2ca17c7
Compare
* rename provider to proxy * try to use instance over class methods
module gets instantiated in rewrite phase
and then reused and called with self in each other phase
that allows modules to have internal state across the request
example:
```lua
local _M = { }
local mt = { __index = _M }
function _M.new()
return setmetatable({ id = 42 }, mt)
end
function _M:rewrite()
local id = self.id
ngx.say(id) -- prints 42
end
```
using context for everything is not performant as having local state also it is easier to test and reason about when everything is encapsulated in one object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the series of PRs trying to get rid of the global configuration store.
That would allow us to implement multi-tenancy, configuration lazy loading (per host),
proper expiration and just better unit testing the whole thing.
The idea behind this is paving path forward the
per request configuration store (#224).
Then every proxy object could have own configuration loaded from somewhere else.
Changes to the interface are not final and likely will be changed in further PRs.
/cc @davidor