-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[env] one way to control openssl peer verification #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spell Checker found issuesdoc/parameters.md
examples/ssl-verification/README.md
Spell Checker found issuesdoc/parameters.md
examples/ssl-verification/README.md
Generated by 🚫 Danger |
mikz
force-pushed
the
openssl-verify
branch
5 times, most recently
from
March 24, 2017 13:10
e985b22
to
4730e25
Compare
still is off by default, but at least can be turned on
use ca-bundle from curl and override it inside s2i image: 3scale/s2i-openresty#24
mikz
force-pushed
the
openssl-verify
branch
2 times, most recently
from
March 24, 2017 13:35
d4d78f8
to
5e52347
Compare
unfortunately this can't be behind a flag
mikz
commented
Mar 24, 2017
apicast/libexec/boot.lua
Outdated
@@ -0,0 +1,10 @@ | |||
#!/usr/bin/env resty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be removed and same changes applied to the keycloak configuration loader
mikz
force-pushed
the
openssl-verify
branch
2 times, most recently
from
March 27, 2017 08:24
54ee4a0
to
72b00eb
Compare
[nginx] proxy ssl verification off by default because it would be off in the resulting docker image so better to have it the same in development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still is off by default, but at least can be turned on
closes #322
APIcast <> 3scale AMP
Connection can be verified by setting the
OPENSSL_VERIFY
env variable totrue
.It is off by default.
APIcast <> upstream
Is also off by default. Can be enabled by injecting custom config
apicast.d/proxy_ssl.conf
with following content:proxy_ssl_verify on;
CA Bundle
Both verifications are set up to use the operating system's ca bundle.