-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend authorization cache handlers #396
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spell Checker found issuesdoc/parameters.md
Generated by 🚫 Danger |
mikz
force-pushed
the
backend-unavailable
branch
from
August 3, 2017 13:01
97d64ff
to
60402c6
Compare
on some systems it can't find it
so it does not conflict with any installed modules
fixup extracted backend handling test extract backend cache handler into own file
mikz
force-pushed
the
backend-unavailable
branch
from
August 4, 2017 07:18
57a3db3
to
1146fcd
Compare
mikz
changed the title
[wip] options to handle response when backend is unavailable
Backend authorization cache handlers
Aug 4, 2017
Haven't tried yet, but looks good. |
proxy.shared_cache = function()
end |
fix and simplify tests with cache handler rename failure cache handler to resilient don't duplicate writes to the cache document how to configure backend cache handler
mikz
force-pushed
the
backend-unavailable
branch
from
August 4, 2017 12:36
1146fcd
to
c581509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract how cache is treated based on the backend response into a module.
It allows extension by adding custom handlers like:
strict is the original handler
resilient is the new handler
It also allows overriding
proxy.shared_cache
method to create custom cache instance for all proxies.That can be useful when replacing local shared memory cache with something like redis.
TODO