Conditional policy #812
Merged
Conditional policy #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a first very basic version of the conditional engine.
davidor
commented
Jul 12, 2018
| "description": "the policy chain to execute when the condition is true", | ||
| "type": "array", | ||
| "items": { | ||
| "type": "object" |
There was a problem hiding this comment.
I know this is not exactly what we need.
mikz
reviewed
Jul 17, 2018
t/apicast-policy-conditional.t
Outdated
| "services": [ | ||
| { | ||
| "id": 42, | ||
| "backend_version": 1, |
There was a problem hiding this comment.
We should not need those when APIcast (3scale) policy is not active, right?
mikz
approved these changes
Jul 17, 2018
davidor
force-pushed
the
conditional-policy
branch
from
dae218c to
e6f2187
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #744
This implements the conditional policy as discussed in #744
The conditional engine is very simple and it's not how the final version will look at all. However, I decided to open this PR in case it helps unblock some of the work going on in ostia.
@mikz let me know if you'd like to have this first version merged soon. Otherwise, I'll start working on a more complex conditional engine (wip branch here: https://github.com/3scale/apicast/tree/lpeg-grammar-condition-engine)