Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to place the batcher policy after APIcast policy in the chain #823

Merged
merged 3 commits into from
Jul 31, 2018

Conversation

davidor
Copy link
Contributor

@davidor davidor commented Jul 25, 2018

The batcher policy was not working correctly when placed after the APIcast policy in the chain.
This PR fixes the issue.

@davidor davidor requested a review from a team as a code owner July 25, 2018 15:52
@@ -173,6 +173,15 @@ local function handle_backend_error(self, service, transaction, cache_handler)
end
end

function _M:rewrite(context)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused argument 'self'

@davidor davidor force-pushed the batcher-policy-order branch from f501e29 to 9fb5832 Compare July 25, 2018 15:54
@davidor davidor changed the title Allow to place ther batcher policy after APIcast policy in the chain Allow to place the batcher policy after APIcast policy in the chain Jul 26, 2018
@davidor davidor requested a review from mikz July 31, 2018 12:52
Copy link
Contributor

@mikz mikz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good catch!

@davidor davidor force-pushed the batcher-policy-order branch from 9fb5832 to cad9374 Compare July 31, 2018 13:53
@davidor
Copy link
Contributor Author

davidor commented Jul 31, 2018

Rebased on top of master and solved conflicts in the changelog.

@davidor davidor force-pushed the batcher-policy-order branch from cad9374 to 6bc3021 Compare July 31, 2018 14:20
@davidor davidor merged commit 8369dc7 into master Jul 31, 2018
@davidor davidor deleted the batcher-policy-order branch July 31, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants