Add missing semicolon in proxy SSL settings #927
Conversation
|
@3scale/apicast-core need some help with fixing the test... When running locally with |
t/mutual-ssl.t
Outdated
|
|
||
| === TEST 2: Mutual SSL with password file | ||
| --- main_config | ||
| env APICAST_PROXY_HTTPS_PASSWORD_FILE=$Test::Nginx::Util::ServRoot/html/passwords.file; |
There was a problem hiding this comment.
We do not use main_config because this is a blackbox test.
You can use env block like https://github.com/3scale/apicast/blob/620c1b269fafa29068e35b93c0c3e83de4ccf920/t/http-proxy.t#L15-L18
mayorova
force-pushed
the
fix-missing-semicolon-proxy-ssl
branch
from
8ff5234 to
3827272
Compare
| ); | ||
|
|
||
| run_tests(); | ||
|
|
||
| __DATA__ | ||
| === TEST 1: mutual SSL | ||
|
|
||
| === TEST 1: Mutual SSL with password file |
There was a problem hiding this comment.
Maybe adding a new test would have been better so we can be sure that it works with and without the password file.
There was a problem hiding this comment.
@davidor I tried that first... (kept removing the original test as a new commit)
It didn't work. For some reason, even having the same exact WORKING test 2 times in the t/mutual-ssl.t was failing :/
Starting APIcast with
APICAST_PROXY_HTTPS_PASSWORD_FILEwas failing with:Apparently, it's because of the missing
;in the end of the directive.The same for
proxy_ssl_session_reuse, although I didn't really try it.