Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI command to push policy schemas #992

Merged
merged 4 commits into from
Mar 11, 2019
Merged

Conversation

davidor
Copy link
Contributor

@davidor davidor commented Mar 11, 2019

This PR fixes a couple of issues with the 'push_policy' command introduced in #986

davidor added 2 commits March 11, 2019 18:28
Notice that there was a 'token:url' in the code and the tests instead of
'token@url'. While at it, I've changed this to send it via params
because that makes the tests a bit easier (do not need to convert things
to base64) and it's closer to what the system UI shows because
'access_token' appears as a param there.
@davidor davidor requested a review from a team as a code owner March 11, 2019 17:33
@davidor davidor requested a review from a team as a code owner March 11, 2019 18:22
@davidor davidor merged commit 1536d9d into master Mar 11, 2019
@davidor davidor deleted the fix-push-policies-command branch March 11, 2019 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants