Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance DSL for git repos #70

Merged

Conversation

davetron5000
Copy link
Contributor

Since it's currently not trivial to run a private Bower repo, if I want to share internal resources using bower, I have to use Git urls. Since bower-rails makes a nice DSL already, it would be handy if we could specify the version as we do in bundler and have bower-rails sort out the specifics of piecing together the dependency URL. This'll make a bit less friction for Rails devs editing Bowerfile.

This mimics (sort of) the bundler way of doing things:

    asset 'foo', '1.2.3', git: '[email protected]:initech/foo'
    # same as
    asset 'foo', '[email protected]:initech/foo#1.2.3'
@SergeyKishenin
Copy link
Collaborator

Thanks for the PR but if i'm not mistaken bower provides such asset "secret_logic", "git@github:initech/secret_logic#1.0.0" syntax out of the box? Checkout bower resolvers https://github.com/bower/bower/tree/master/lib/core/resolvers?

@davetron5000
Copy link
Contributor Author

Yeah, I'm aware of that and have been using it, but wanted to make it a bit more bundler-like (as that seems to be how the Bowerfile syntax was designed) and more clear as to the intention. You can see that the implementation just creates a git url how you describe. Essentially, it's a convenience function.

@SergeyKishenin
Copy link
Collaborator

OK!

SergeyKishenin added a commit that referenced this pull request Apr 6, 2014
@SergeyKishenin SergeyKishenin merged commit 92cb17a into rharriso:master Apr 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants