Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract performer class for rake tasks #95

Merged
merged 8 commits into from
Jul 20, 2014

Conversation

Melanitski
Copy link
Contributor

For fixing issue #94
Can you apply it, please?

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 9480298 on Rademade:master into 0c298d9 on 42dev:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 95cdec0 on Rademade:master into 0c298d9 on 42dev:master.

@SergeyKishenin
Copy link
Collaborator

Is it going in addition to configurable root_path feature?

Also, resolve_asset_paths and remove_extra_files methods for related rake tasks won't work, I guess.

@Melanitski
Copy link
Contributor Author

It isn't addition, it would have few conflicts. I can slove it.

@Melanitski
Copy link
Contributor Author

What we can fix for merge your pull request?
It's very important to your gem. Thanks

@SergeyKishenin
Copy link
Collaborator

Well, you can merge issue-94 branch and depend everywhere on BowerRails.root_path.

Also, as I said before there is something wrong with resolve_asset_paths and remove_extra_files methods. Now you call only perform instance method in perform class one. So

BowerRails::Performer.perform false do
  resolve_asset_paths
end

won't work, right?

This should be fixed too. Thanks.

Conflicts:
	lib/bower-rails/dsl.rb
	lib/tasks/bower.rake
@coveralls
Copy link

Coverage Status

Coverage increased (+0.14%) when pulling 0babdaf on Rademade:master into 0c298d9 on 42dev:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.14%) when pulling 8f37e8d on Rademade:master into 0c298d9 on 42dev:master.

@Melanitski
Copy link
Contributor Author

Already merged issue-94 to master
Also fix methods resolve_asset_paths and remove_extra_files in performer.

Could you apply pull request and update gem version please?

@SergeyKishenin
Copy link
Collaborator

Thanks!

SergeyKishenin added a commit that referenced this pull request Jul 20, 2014
Extract performer class for rake tasks
@SergeyKishenin SergeyKishenin merged commit 76fceee into rharriso:master Jul 20, 2014
SergeyKishenin added a commit that referenced this pull request Jul 20, 2014
SergeyKishenin added a commit that referenced this pull request Jul 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants