Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List user repositories api #224

Merged
merged 1 commit into from
Oct 9, 2018
Merged

List user repositories api #224

merged 1 commit into from
Oct 9, 2018

Conversation

pgabara
Copy link

@pgabara pgabara commented Oct 7, 2018 •
edited
Loading

fixes #194

juanpedromoreno
juanpedromoreno approved these changes Oct 7, 2018
View reviewed changes
Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran all the tests locally and they're all green 👌

Thanks @bhop for your time!

@pgabara
Copy link
Author

pgabara commented Oct 7, 2018 •
edited
Loading

Thanks @juanpedromoreno.

I wonder why tests are failing here. Maybe there is a problem with a Github token?

BenFradet
BenFradet reviewed Oct 8, 2018
View reviewed changes
Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent, thanks 👍 ! Could you just remove some of the indentation-related noise from the PR?

github4s/shared/src/main/scala/github4s/api/PullRequests.scala Outdated Show resolved Hide resolved
github4s/shared/src/main/scala/github4s/api/Repos.scala Outdated Show resolved Hide resolved
@juanpedromoreno
Copy link
Member

@bhop Yup, the integrations tests failed because only the maintainers have access to the API key. In those cases, we need to run them manually.

BenFradet
BenFradet approved these changes Oct 9, 2018
View reviewed changes
Copy link
Contributor

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👍 , do you need this released?

@BenFradet BenFradet merged commit 3512f38 into 47degrees:master Oct 9, 2018
@pgabara
Copy link
Author

pgabara commented Oct 9, 2018

No rush. I wanted to contribute to the project and I thought this might be a good starting point :)

@BenFradet
Copy link
Contributor

Cool, shout when you need a release 👍

@pgabara pgabara deleted the list-user-repos branch October 9, 2018 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

@BenFradet BenFradet BenFradet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for the list user repositories endpoint
3 participants
@pgabara @juanpedromoreno @BenFradet