Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible duplicity #136

Closed
AdrianRaFo opened this issue May 17, 2017 · 1 comment
Closed

Possible duplicity #136

AdrianRaFo opened this issue May 17, 2017 · 1 comment

Comments

@AdrianRaFo
Copy link
Contributor

AdrianRaFo commented May 17, 2017 •
edited
Loading

We have postAuth and postOAuth in httpClient.
The first receive a header built by the method in Auth API.
The second not receives a header but add one by himself.

Is possible delete postOuth and pass his header on the method?
@bilki
Copy link

bilki commented Jul 11, 2019

Does this suggestion still apply? Both postAuth and postOAuth in the current master branch receive a headers argument of type Map[String, String], but the first one builds the url from the auth method, and the second one just posts into the provided url parameter.

I would keep them the way they are right now because semantics are different. Do you mind if we close this ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bilki @AdrianRaFo