Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label id is Long, not Int #529

Closed
dcsobral opened this issue Jul 16, 2020 · 2 comments
Closed

Label id is Long, not Int #529

dcsobral opened this issue Jul 16, 2020 · 2 comments

Comments

@dcsobral
Copy link
Contributor

I'm getting errors on new repositories because new labels are not getting ids that are greater than Int.MaxValue. For example: https://api.github.com/repos/precog/quasar-datasource-kafka/labels/:robot:

{
  "id": 2167724672,
  "node_id": "MDU6TGFiZWwyMTY3NzI0Njcy",
  "url": "https://api.github.com/repos/precog/quasar-datasource-kafka/labels/:robot:",
  "name": ":robot:",
  "color": "ffffff",
  "default": false,
  "description": ""
}

It fails to decode with this as the cause:

DecodingFailure(Int, List(DownField(id), DownArray))

A quick check revealed that 2167724672 is not an Int:

scala> 2167724672
<console>:1: error: integer number too large
@juanpedromoreno
Copy link
Member

I believe this has been already fixed in #523, hopefully there will be a release soon

@dcsobral
Copy link
Contributor Author

@juanpedromoreno Indeed. That should teach me to look at the actual code instead of the code for the version I'm using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants