Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataFileUpdateService: If-Modified-Since is not in GMT #96

Closed
justadreamer opened this issue Mar 7, 2024 · 1 comment
Closed

dataFileUpdateService: If-Modified-Since is not in GMT #96

justadreamer opened this issue Mar 7, 2024 · 1 comment
Assignees
Labels
type: bug Something isn't working

Comments

@justadreamer
Copy link
Contributor

Background

If you use a custom data File URL and you are not in GMT timezone - you will see that the If-Modified-Since header created here is not in GMT, but in local time zone.

According to https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-Modified-Since HTTP dates are always expressed in GMT, never in local time.

Objective

  1. Please convert it to UTC, using .toUTCString() applied to that date.
  2. Please make sure to add a test that verifies that If-Modified-Since is expressed in the GMT time zone
@justadreamer justadreamer added the type: bug Something isn't working label Mar 7, 2024
@justadreamer
Copy link
Contributor Author

fixed as part of #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants