From 0395928091f25ba77dfa88d653357f7ac42ac525 Mon Sep 17 00:00:00 2001 From: Kevin Berry <41717340+51ngul4r1ty@users.noreply.github.com> Date: Thu, 25 Jan 2024 09:51:07 -0500 Subject: [PATCH 1/3] Fix backlog item update stays in edit mode after save issue --- .../src/server/api/handlers/backlogItems.ts | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/web-app/src/server/api/handlers/backlogItems.ts b/packages/web-app/src/server/api/handlers/backlogItems.ts index 61028f6..1bf75fb 100644 --- a/packages/web-app/src/server/api/handlers/backlogItems.ts +++ b/packages/web-app/src/server/api/handlers/backlogItems.ts @@ -378,10 +378,10 @@ export const backlogItemPutHandler = async (req: Request, res: Response) => { newDataItem.unallocatedPoints = requestApiBacklogItem.estimate; } await backlogItem.update(newDataItem, { transaction }); - const responseBacklogItem = mapApiItemToBacklogItem(backlogItem); - responseBacklogItem.storyEstimate = responseBacklogItem.estimate; // just updated the story estimate - responseBacklogItem.unallocatedPoints = responseBacklogItem.estimate; // all are in backlog - await handleResponseAndCommit(originalApiBacklogItem, responseBacklogItem, res, transaction); + const responseApiBacklogItem = mapDbToApiBacklogItem(backlogItem); + responseApiBacklogItem.storyEstimate = responseApiBacklogItem.estimate; // just updated the story estimate + responseApiBacklogItem.unallocatedPoints = responseApiBacklogItem.estimate; // all are in backlog + await handleResponseAndCommit(originalApiBacklogItem, responseApiBacklogItem, res, transaction); } } catch (err) { const errLogContext = logger.warn(`handling error "${err}"`, [functionTag], logContext); @@ -556,15 +556,15 @@ export const backlogItemJoinUnallocatedPartsPostHandler = async (req: Request, r const handleResponseAndCommit = async ( originalApiBacklogItem: ApiBacklogItem, - backlogItem: BacklogItemDataModel, + apiBacklogItem: ApiBacklogItem, res: Response, transaction: Transaction ): Promise => { let sprintStats: ApiSprintStats; - const originalBacklogItem = mapApiItemToBacklogItem(originalApiBacklogItem); + // const originalBacklogItem = mapApiItemToBacklogItem(originalApiBacklogItem); if (transaction) { await transaction.commit(); transaction = null; } - respondWithItem(res, backlogItem, originalBacklogItem, sprintStats ? { sprintStats } : undefined); + respondWithItem(res, apiBacklogItem, originalApiBacklogItem, sprintStats ? { sprintStats } : undefined); }; From 1bb07ebaff04d21fe4552be5c672343eda4e454f Mon Sep 17 00:00:00 2001 From: Kevin Berry <41717340+51ngul4r1ty@users.noreply.github.com> Date: Thu, 25 Jan 2024 09:52:05 -0500 Subject: [PATCH 2/3] fix backlog item status numeric error log --- packages/web-app/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web-app/package.json b/packages/web-app/package.json index b14b2d7..fa68741 100644 --- a/packages/web-app/package.json +++ b/packages/web-app/package.json @@ -1,6 +1,6 @@ { "name": "@atoll/web-app", - "version": "0.64.0", + "version": "0.64.1", "description": "Atoll web app", "scripts": { "build": "npm run build-only && npm run build-deploy", From 78f524a1588de1713ba7bd5f447d523264d5a477 Mon Sep 17 00:00:00 2001 From: Kevin Berry <41717340+51ngul4r1ty@users.noreply.github.com> Date: Thu, 25 Jan 2024 09:52:39 -0500 Subject: [PATCH 3/3] clean up --- packages/web-app/src/server/api/handlers/backlogItems.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/web-app/src/server/api/handlers/backlogItems.ts b/packages/web-app/src/server/api/handlers/backlogItems.ts index 1bf75fb..4888c4f 100644 --- a/packages/web-app/src/server/api/handlers/backlogItems.ts +++ b/packages/web-app/src/server/api/handlers/backlogItems.ts @@ -561,7 +561,6 @@ const handleResponseAndCommit = async ( transaction: Transaction ): Promise => { let sprintStats: ApiSprintStats; - // const originalBacklogItem = mapApiItemToBacklogItem(originalApiBacklogItem); if (transaction) { await transaction.commit(); transaction = null;