Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dances.modes.*.lineHighlight is not working #204

Closed
pbzweihander opened this issue Oct 5, 2021 · 1 comment
Closed

dances.modes.*.lineHighlight is not working #204

pbzweihander opened this issue Oct 5, 2021 · 1 comment

Comments

@pbzweihander
Copy link

I want to distinguish modes with color (#13) but it seems like dances.modes.*.lineHighlight is not working

My configuration is:

{
	// ...
    "dance.modes": {
        "insert": {
            "cursorStyle": "line-thin",
            "decorations": null,
            "lineHighlight": "#282a36"
        },
        "normal": {
            "cursorStyle": "line",
            "lineNumbers": "on",
            "decorations": null,
            "lineHighlight": "#3a3d4d"
        },
	},
	// ...
}
@71
Copy link
Owner

71 commented Oct 5, 2021

My bad, lineHighlight was deprecated a while ago in favor of decorations, but this wasn't documented. Your snippet becomes

{
    "dance.modes": {
        "insert": {
            "cursorStyle": "line-thin",
            "decorations": {
                "applyTo": "main",
                "backgroundColor": "#282a36",
                "isWholeLine": true,
            },
        },
        "normal": {
            "cursorStyle": "line",
            "lineNumbers": "on",
            "decorations": {
                "applyTo": "main",
                "backgroundColor": "#3a3d4d",
                "isWholeLine": true,
            },
        },
    },
}

7245eca properly marks lineHighlight as deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants