Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppscore when model_score>baseline_score #51

Open
bimhud opened this issue Mar 1, 2021 · 3 comments
Open

ppscore when model_score>baseline_score #51

bimhud opened this issue Mar 1, 2021 · 3 comments

Comments

@bimhud
Copy link

bimhud commented Mar 1, 2021

Not sure why ppscore is still zero when model_score>baseline_score

Capture

@FlorianWetschoreck
Copy link
Collaborator

Thank you for reporting this. That really seems odd. Can you create a reproducible code example?

@bimhud
Copy link
Author

bimhud commented Mar 1, 2021

@FlorianWetschoreck it's a standard call of the pps.predictors(df, "y"). The given dataframe contains small percentage of missing values. Numeric columns and category columns are also provided from the dataframe. No thing is really strange about the dataset. Unfortunately, it is unable to provide the dataset for re-producible. Just think about the what factor contributing to ppscore to make it become zero in this situation.

@FlorianWetschoreck
Copy link
Collaborator

Thank you for your reply.

I was confused before - the behavior is exactly what we want to have because:
For the mean absolute error, better means lower e.g. closer to 0. As you can see above, the baseline is lower than the model and thus, the PPS is 0 because the model is worse than the baseline.
This might be a little bit confusing because for the PPS higher is better but for MAE lower is better.

I hope that helps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants