Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working in Register page #51

Open
krishnainnodel opened this issue Jan 30, 2023 · 5 comments
Open

Not working in Register page #51

krishnainnodel opened this issue Jan 30, 2023 · 5 comments

Comments

@krishnainnodel
Copy link

HI,
I have added this plugin and added code of checkout address fields in my account register page. But city filter is not working in register page.

@Mantish
Copy link
Member

Mantish commented Feb 2, 2023

Hi @krishnainnodel . Can you share more details about this?
What verion of WP and WC are you using?
So you have some code you can share or can you tell us how you're adding the address fields to the register page?

@Mantish
Copy link
Member

Mantish commented May 13, 2024

This is the issue reported here in the WP: https://wordpress.org/support/topic/is-this-plugin-still-compatible-with-woocommerce-checkout-page/

The issue affects users with new installations of WooCommerce 8.3+, because the Cart and Checkout Blocks are the default now.

A first step for this is to declare incompatibility as explained here https://developer.woocommerce.com/2023/11/06/faq-extending-cart-and-checkout-blocks/

But it should be possible to make the plugin compatible. We probably just need to accept 2 different IDs for the city fields: billing-city and billing_city.

Any contributions to fix this issue are highly appreciated

@sebafehlandt-spotmind
Copy link

Hi, any chance you make this compatible with Checkout blocks?

@sfehlandt
Copy link
Contributor

Hi (I'm the same person as above, just using my personal account now).

I just submitted a PR adding Chilean cities: #54

If you think it should be easy to make the plugin compatible with Checkout blocks I am happy to help

@Mantish
Copy link
Member

Mantish commented Jul 30, 2024

Hi @sfehlandt ,
Yeah, I haven't really look into this code or the Checkout Blocks, but from what I understand it wouldn't be too hard to make it work.
My guess is that making the plugin work with both billing-city and billing_city as ids for the city fields is all that's needed.
If you'd like to start a PR, I'll be happy too review it and test it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants