feat: ❇️ added moving and copying folders api #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Aydawka
commented
Jan 23, 2024
•
Aydawka
commented
- Added moving folders api: moves directory along with the files in it
- Added copying folders api: copies directory in the source and moves directory to the destination folder.
# Conflicts: # function_app.py
|
@megasanjay I have updated this branch. let me know please if anything else is needed |
|
These endpoints should be in their own files |
|
@megasanjay Since all endpoints are in the same destination, they were also located there. In that case I need to move them to other file since they are logically different from other endpoints? |
|
The new file should probably be in the utils directory. Also does the move function not implement overwrite protections? |
|
@megasanjay It does, if overwrite bool is false file can not be moved. If it is true then it will move to the new destination |
megasanjay
approved these changes
Feb 7, 2024
megasanjay
added a commit
that referenced
this pull request
May 30, 2024
* 🚧 wip: add sql connection * 🚧 wip: add study_description metadata * 🚧 wip: add study_description.json metadata * 🚧 wip: add study_description.json metadata * 🚧 wip: add study_description.json metadata * ✨ feat: add study_description.json metadata * ✨ feat: generate study_description.json metadata * ✨ feat: generate dataset_description.json * ✨ feat: generate readme.md * 🐛 fix: remove print * 🧱 chore: add publish workflow pipeline * chore: generate mermaid diagrams Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: ✨ validation checks for study and dataset description (#2) * 🚧 wip: removing empty strings from study metadata when optional * ✨ feat: validation checks for study description * feat: dataset description validations * 🐛 fix: updated validation checks * 🔨 chore: remove prints * 🔨 chore: formatting * feat: ✨ Datatype generation (#5) * 🚧 wip: setup base for datatype generation * 🚧 wip: gather folders from specified container * ✨ feat: generate datatype dictionary to azure * feat: added resources license to readme and changelog, license scripts (#6) * feat: added generate license script * fix: dataset readme description * fix: license script * feat: dataset changelog script * fix: dataset readme script * fix: dataset discovery metadata * fix: modified changelog text * style: format * fix: license generation * fix: readme generation * fix: remove redundant print * fix: remove incorrect comment * feat: ❇️ added moving and copying folders api (#8) * feat: added folder relocation function in azure * feat: added moving folder api * fix: remove moving folder file * feat: added copying folders api * style: format * fix: error * fix: connection_string called from env * fix: modified directory locations * fix: added minor comment for copying function * fix: added query params for overwriting directories * style: format * fix: prevent copying destination into itself * fix: add moving destination with query params * fix: add moving destination with query params * fix: modified moving folders * fix: optimize and clear copying and moving controller * style: format * fix: revised file operation * fix: revised file operation * chore: generate mermaid diagrams Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: ✨ doi registration (#9) * 🚧 wip: add doi registration * 🚨 chore: appease the linter * 🎨 style: fix code style issues with Black * ✨ feat: add doi generation from test.datacite * 🚧 wip: create payload to register datasets doi * chore: generate mermaid diagrams Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * 🎨 style: fix code style issues with Black * 🚧 wip: gather all date for doi registration payload * 🚧 wip: correcting payload for doi registration * 🎨 style: fix code style issues with Black * ✨ feat: doi registration complete * 🎨 style: fix code style issues with Black --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sanjay Soundarajan <[email protected]> Co-authored-by: Lint Action <[email protected]> Co-authored-by: slugb0t <[email protected]> * feat: ✨ add get file structure endpoint (#11) * feat: add get file tree * fix: format * fix: format * style: format * chore: generate mermaid diagrams Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * ✨ feat: add support for datacite v4.5 (#10) * ✨ feat: add support for datacite v4.5 * 🐛 fix: update dataset publisher * 🐛 fix: managing organization key in dataset metadata * 🐛 fix: add funderIdentifierType to funderIdentifier * ✨ feat: update study_description (#12) * 🐛 fix: add more datacite changes * ✨ feat: update study_description * refactor: ♻️ conversion function transfer (#14) * ✨ feat: convert function transferred to pyfairdatatools * ♻️ refactor: call updated columns on managing org table * ♻️ refactor: call new table for managing org * 🔨 chore: remove unused modules * ✨ working doi registration with conversion fn transfer * chore: generate mermaid diagrams Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dorian Portillo <[email protected]> Co-authored-by: megasanjay <[email protected]> --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Dorian Portillo <[email protected]> Co-authored-by: megasanjay <[email protected]> --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: megasanjay <[email protected]> Co-authored-by: Dorian Portillo <[email protected]> Co-authored-by: Aydan Gasimova <[email protected]> Co-authored-by: Lint Action <[email protected]> Co-authored-by: slugb0t <[email protected]> Co-authored-by: Dorian Portillo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.