Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS: Automated detection of particles #104

Closed
mhubii opened this issue Sep 9, 2024 · 7 comments
Closed

JOSS: Automated detection of particles #104

mhubii opened this issue Sep 9, 2024 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@mhubii
Copy link

mhubii commented Sep 9, 2024

Sorry as somewhat of a newbie here..

I ran Detection -> Use Example Model -> Detect with default settings. (https://particletracking.readthedocs.io/en/latest/RodTracker/RodTracker.html#automated-detection-of-particles)

The result only detected sporadically, see below

rodtracker_results.mp4

Any explanation for why the presented method does not auto-detect, as claimed? I assume with depth information and instance segmentation, this should be possible. Please advise.

Refers to openjournals/joss-reviews#5986

@mhubii mhubii added the bug Something isn't working label Sep 9, 2024
@mhubii mhubii changed the title JOSS: Inference JOSS: Automated detection of particles Sep 9, 2024
@dmitrypuzyrev
Copy link
Collaborator

Hello @mhubii,
can you please describe what steps you've made here exactly?
It seems that you've run 2D detection for one camera view for blue color, and then you are plotting only rod number 0.
In each frame on your video this corresponds to one of the detected objects, but it jumps from object to object because detected rods are not yet sorted (tracked).
Because tracking/view matching is performed in 3D, to get reasonable tracking results you also need to run detection for the second view, load the example stereo calibration data and then run detection on selected frame:
https://particletracking.readthedocs.io/en/latest/RodTracker/RodTracker.html#rod-tracking-and-3d-coordinate-reconstruction
Did you perform those steps as well?

@mhubii
Copy link
Author

mhubii commented Sep 9, 2024

no worries, so I just followed the instructions and left configurations untouched.

On data: RodTracker/src/RodTracker/resources/example_data/images/gp3

@dmitrypuzyrev
Copy link
Collaborator

dmitrypuzyrev commented Sep 9, 2024

So if you indeed used only one camera data, this behavior is expected, because no 2D tracking was performed at all.
2D tracking would be indeed possible too, but then there would be problems with tracking rods during overlapping and complications with 3D matching too.

By the way, to test the 3D tracking, please use the latest updates on develop branch, there was an issue that prevented proper tracking (Issue #96) which was recently fixed. We will merge the fix to the other branches as well soon.

@mhubii
Copy link
Author

mhubii commented Sep 9, 2024

I mean the tutorial says "Automated detection of particle", so tracking is the expected outcome.

Sorry, but I won't use the develop branch. As per JOSS, this package is expected to work out of the box.

@dmitrypuzyrev dmitrypuzyrev self-assigned this Sep 11, 2024
@dmitrypuzyrev
Copy link
Collaborator

Hi @mhubii,
now the default number of detected particles is increased to 25 for each color (according to the experiment shown on example images).
Most of the particles are automatically detected on the frames.
Please check that it works as expected for you!

@mhubii
Copy link
Author

mhubii commented Oct 22, 2024

I'll check tomorrow. Sorry for the delay

@mhubii
Copy link
Author

mhubii commented Jan 13, 2025

this seems fixed

@mhubii mhubii closed this as completed Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants