Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS: No more than 2 digits #111

Open
mhubii opened this issue Jan 13, 2025 · 2 comments
Open

JOSS: No more than 2 digits #111

mhubii opened this issue Jan 13, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@mhubii
Copy link

mhubii commented Jan 13, 2025

Under 3D-Reconstruct, I cannot type in start / end frame with more than 2 digits, is this a general issue?

Screenshot from 2025-01-13 13-53-05

This issue is also apparent for all other inputs. Somehow the GUI doesn't support it. Please fix.

Refers to openjournals/joss-reviews#5986

@mhubii mhubii added the bug Something isn't working label Jan 13, 2025
@mhubii mhubii changed the title JOSS: No 3 digits or more JOSS: No more than 2 digits Jan 13, 2025
@dmitrypuzyrev
Copy link
Collaborator

Hi @mhubii ,

I have checked the code and it is the intended behavior.
The inputs here are realized by QSpinBox widgets. Until no image data are loaded, they have default range 0..99.
As soon as image frames are loaded, they change to a proper range min_frame..max_frame.
This seems alright to me, do you think it is a problem? The only possible change I can think of is to completely disable them somehow until no images are loaded, but I don't think it is a really meaningful improvement.

@mhubii
Copy link
Author

mhubii commented Feb 7, 2025

Well when I loaded data they were ranging from 500 to 520 or so. I wasn't able to select images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants