From 7900817600fb2ab6536853eb86bfcb5aa3cf3d7d Mon Sep 17 00:00:00 2001 From: Charles Date: Tue, 16 Aug 2022 13:33:14 +0200 Subject: [PATCH] @jcoutant requests --- .../lora/TARGET_STM32WL/STM32WL_LoRaRadio.cpp | 6 ------ .../lora/TARGET_STM32WL/STM32WL_radio_driver.h | 14 +++++++------- 2 files changed, 7 insertions(+), 13 deletions(-) diff --git a/connectivity/drivers/lora/TARGET_STM32WL/STM32WL_LoRaRadio.cpp b/connectivity/drivers/lora/TARGET_STM32WL/STM32WL_LoRaRadio.cpp index 50204ff8d82d..d3b62e7f958b 100644 --- a/connectivity/drivers/lora/TARGET_STM32WL/STM32WL_LoRaRadio.cpp +++ b/connectivity/drivers/lora/TARGET_STM32WL/STM32WL_LoRaRadio.cpp @@ -78,12 +78,6 @@ static uint8_t _active_modem; using namespace std::chrono; using namespace mbed; - -/** - * @brief voltage of vdd tcxo. - */ -//#define TCXO_CTRL_VOLTAGE TCXO_CTRL_1_7V - /*! * FSK bandwidth definition */ diff --git a/connectivity/drivers/lora/TARGET_STM32WL/STM32WL_radio_driver.h b/connectivity/drivers/lora/TARGET_STM32WL/STM32WL_radio_driver.h index 738dc55ad6da..e8877ad165f9 100644 --- a/connectivity/drivers/lora/TARGET_STM32WL/STM32WL_radio_driver.h +++ b/connectivity/drivers/lora/TARGET_STM32WL/STM32WL_radio_driver.h @@ -20,13 +20,13 @@ #define RBI_CONF_RFO_LP_HP 0 #define RBI_CONF_RFO_LP 1 #define RBI_CONF_RFO_HP 2 -// Some boards such as LoRa-E5 and RAK3172 have only RFO_HP wired -// thus in EU868 TX consume 80mA which is over consumption -// We made a fix that decrease consumption according datasheet buy -// since it break machting network hi range may be decresed so it's -// matter of what you want to achieve, choice between range or consumption -// Setting RBI_CONF_RFO_HP_LPFIX decrease power according datashhet but can -// reduce range (long ones) due ti mismatch network on the both modules +// Some boards such as LoRa-E5 and RAK3172 have only RFO_HP path wired +// thus, in EU868 mode, TX peak is 80mA (over consumption) +// We made a fix that decrease consumption according datasheet but +// since fix breaks HW machting network, transmit range may be lowered so +// it's depending on what you want to achieve, hi range or low consumption +// Setting RBI_CONF_RFO_HP_LPFIX decrease power according datasheet but can +// reduce range (long ones) due to bad HW macthing network on the both modules // See https://github.com/ARMmbed/mbed-os/pull/15017#issuecomment-1173455762 #define RBI_CONF_RFO_HP_LPFIX 3