Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bugs of search_params; #322

Merged
merged 1 commit into from
Jul 19, 2023
Merged

fix bugs of search_params; #322

merged 1 commit into from
Jul 19, 2023

Conversation

Gordon119
Copy link
Collaborator

What does this PR do?

Fix some bugs in search_params.py:

  1. Test result won't dump to log.
  2. Logging message is the same for retrain and no retrain.

Test CLI & API (bash tests/autotest.sh)

Test APIs used by main.py.

  • Test Pass
    • All tests finished (13/13) on fix-search_params.py-bugs. See test_report.txt for details.
  • Not Applicable (i.e., the PR does not include API changes.)

Check API Document

If any new APIs are added, please check if the description of the APIs is added to API document.

  • API document is updated (linear, nn)
  • Not Applicable (i.e., the PR does not include API changes.)

Test quickstart & API (bash tests/docs/test_changed_document.sh)

If any APIs in quickstarts or tutorials are modified, please run this test to check if the current examples can run correctly after the modified APIs are released.

@Gordon119 Gordon119 merged commit c793509 into master Jul 19, 2023
@Eleven1Liu Eleven1Liu deleted the fix-search_params.py-bugs branch July 25, 2023 01:25
@Eleven1Liu Eleven1Liu restored the fix-search_params.py-bugs branch July 25, 2023 01:25
@Eleven1Liu Eleven1Liu deleted the fix-search_params.py-bugs branch September 6, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working parameter-search
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants