Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something about the Triangle.class #25

Open
ruizi opened this issue Nov 14, 2020 · 3 comments
Open

Something about the Triangle.class #25

ruizi opened this issue Nov 14, 2020 · 3 comments

Comments

@ruizi
Copy link

ruizi commented Nov 14, 2020

Something about the Triangle.class in the package of org.avmframework.examples.inputdatageneration.triangle

From Line 33 to Line 37, if it is in the scenario of num1 being equal to num2 but num2 is not equal to num3, the logic will regard the triangle as SCALENE, but actually, it should be ISOSCELES (num1 = num2).
Screen Shot 2020-11-14 at 9 43 50 PM

@nikhilty
Copy link

nikhilty commented Nov 13, 2022

This works as it should

  1. If num1 == num2 & num2 == num3 - Then type is EQUILATERAL.
  2. Else If num1 == num2 - Then Type is ISOSCELES
  3. Else if num2 == num3 - Then type is ISOSCELES

@ruizi
Copy link
Author

ruizi commented Nov 22, 2022

If you go through the code logic at line 35 with the example of (num1 = 3, num2 = 3 and num3 = 1) then, the code will output SCALENE. But actually, the triangle is ISOSCELES

@ruizi
Copy link
Author

ruizi commented Nov 22, 2022

It will not go into the else logic starting from line 38.

@ruizi ruizi changed the title Something about the Triangle.class in the package of org.avmframework.examples.inputdatageneration.triangle Something about the Triangle.class Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants