Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-D][Tester D] addnote cuts off part of the note if n\ is in the note #213

Closed
nus-se-bot opened this issue Apr 5, 2024 · 2 comments
Closed
Assignees
Labels
type.bug Something isn't working type.documentation Improvements or additions to documentation
Milestone

Comments

@nus-se-bot
Copy link

Current Behaviour

addnote command doesn't handle n\ well, as it may cut off parts of the note if n\ is in the note.

Expected Behaviour

addnote command should handle n\, and not cut off part of a note.

Steps to reproduce

  1. Enter addnote S1234567A n\I can use the addnote command: n\ to add a note

image.png

  1. The note is appended.

image.png

  1. Enter show S1234567A

image.png

  1. We see that only to add a note is kept as the note, but not the full note: I can use the addnote command: n\ to add a note.

Why this is an issue

The string n\ can appear quite commonly. For example, consider this Windows file path C:\Users\John\Documents\example.txt. If one of the notes contains this file path, parts of note could be lost.

This affects usernames and directories that end with n more signficantly, which may be a issue if user wants to store filenames inside their notes for quickly accessing a certain file related to a patient.

Suggested Change

Only accept the first n\ prefix, and treat the following text as part of the message.


Labels: type.FunctionalityBug severity.Medium
original: tituschewxj/ped#13

@jiahui0309 jiahui0309 added the type.bug Something isn't working label Apr 9, 2024
@drustanyjt drustanyjt self-assigned this Apr 10, 2024
@drustanyjt drustanyjt added this to the v1.4 milestone Apr 10, 2024
@drustanyjt drustanyjt added the type.documentation Improvements or additions to documentation label Apr 10, 2024
@drustanyjt
Copy link

Either:

  1. Fix the parser
  2. Update the UG to say not to do this

@drustanyjt
Copy link

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type.bug Something isn't working type.documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants