Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-D][Tester E] Invalid phone number is allowed for Add command #149

Closed
soc-pe-bot opened this issue Apr 5, 2024 · 0 comments · Fixed by #169
Closed

[PE-D][Tester E] Invalid phone number is allowed for Add command #149

soc-pe-bot opened this issue Apr 5, 2024 · 0 comments · Fixed by #169
Assignees

Comments

@soc-pe-bot
Copy link

Description

The 'add' command does not properly validate phone numbers, allowing for non-valid phone numbers to be entered into the application.

Steps to Reproduce

  1. Enter the command add cn/Google n/John Doe p/123 e/[email protected] a/311, Clementi Ave 2, #02-25 tt/121220221400 i/Birthday: 12 May 2001 s/5000 pl/Java t/friends t/owesMoney pri/2
  2. Observe that the application accepts 123 as a valid phone number and adds the record.

Expected Behavior

The application should validate that p/123 is not a valid phone number and prevent the addition of the record until a valid phone number is provided.

Actual Behavior

The application allows an invalid phone number p/123 to be used in the add command and creates a new person record with this invalid phone number.
Invalid Phone Number Error

Additional Information

Proper validation checks for phone number formats should be implemented to ensure that only valid phone numbers are accepted by the 'add' command.


Labels: severity.Low type.FunctionalityBug
original: jmsandiegoo/ped#9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants